Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport relocatability fixes #19

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 20, 2023

As merging gazebosim/gz-sim#1968 upstream is taking some time, let's backport the patch here. While this indeed introduces some new ABI symbols, if the symbols ends being changed in the upstream release, we can always re-introduce them with a custom patch, if that turns out to be necessary.

Similar to conda-forge/gz-physics-feedstock#11 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro changed the title Addreloc Backport relocatability fixes Jun 20, 2023
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gz-sim-feedstock/actions/runs/5321774113.

@traversaro
Copy link
Contributor Author

Currently we also have the warning:

2023-06-20T11:32:05.3161857Z /home/conda/feedstock_root/build_artifacts/gz-sim7_1687259193132/work/src/systems/physics/Physics.cc:805:13: warning: 'GZ_PHYSICS_ENGINE_INSTALL_DIR' macro is deprecated, use gz::physics::getEngineInstallDir() function instead. 
2023-06-20T11:32:05.3162561Z   805 |   systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});
2023-06-20T11:32:05.3163187Z       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  

We should add a local patch for that.

@traversaro traversaro added the automerge Merge the PR when CI passes label Jun 20, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 20, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro traversaro merged commit 4137bdb into conda-forge:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants