Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcxx 17.0.6 #131

Merged
merged 29 commits into from
May 6, 2024
Merged

libcxx 17.0.6 #131

merged 29 commits into from
May 6, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Sep 26, 2023

Biggest change is that libcxx now hard-requires MacOS >=10.13, see #110 (particularly for the dylib, but a simple # include also fails if the SDK is too old). Since libcxx has such a central role in our MacOS stack (i.e. we always pull in newest libcxx), this will effectively mandate a move to 10.13 (as all packages having libcxx in host will generate a run-export on >=17.0.1, which effectively moves all compiled osx-packages to >=10.13), see conda-forge/conda-forge.github.io#1844.

libcxx on linux now also requires glibc >=2.24, which we cannot yet satisfy because our sysroots are too old (and 2_28 hasn't materialized yet); this doesn't seem too big of an issue though, as libcxx-on-linux is not our default C++ stdlib and is used very little.

I've kept the compatibility with old clang by again rebasing the revert of llvm/llvm-project@21f73d5; we're already far beyond the upstream support policy of "last 2 clang versions" by going back all the way to clang 11. This remains on a best-effort basis.

Closes #110

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

The error here does not make sense to me:

RuntimeError: Solver could not find solution.Mamba failed to solve:
 - __osx >=10.13
 - libcxx-testing 0.15.*
 - libcxx 17.0.1.* hdf9962f_0

with channels:

The reported errors are:
- Encountered problems while solving:
-   - package libcxx-testing-0.15-h007348e_1 is excluded by strict repo priority

as the package in question is definitely in the main channel.

@h-vetinari
Copy link
Member Author

This is running into conda-forge/python-symengine-feedstock#50

@h-vetinari
Copy link
Member Author

With the imminent merge of conda-forge/conda-forge-pinning-feedstock#5829, this is not a draft anymore - please feel free to review @conda-forge/libcxx :)

I feel this PR is in a good shape though, so planning to merge after Monday EOD AoE unless there are comments.

@h-vetinari h-vetinari merged commit 83f6f06 into conda-forge:main May 6, 2024
5 checks passed
@h-vetinari h-vetinari deleted the 17 branch May 6, 2024 18:16
beenje added a commit to beenje/fisx-feedstock that referenced this pull request May 14, 2024
osx-64 build failed when merging into main because libcxx was updated from 16.x.x
to 17.x.x between the time of the MR and the merge.
libcxx 17.x.x requires MacOS >=10.13 (see conda-forge/libcxx-feedstock#131)

My understanding is that a re-render should fix it due to conda-forge/conda-forge-pinning-feedstock#5829
@h-vetinari h-vetinari mentioned this pull request May 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream planning to move to 10.13 minimum MacOS SDK
3 participants