Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sysroot_* to {{ stdlib('c') }} #149

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 9, 2024

Follows up on this suggestion ( #147 (review) ), to align with broader move away from sysroot_* to {{ stdlib('c') }} ( conda-forge/conda-forge.github.io#2102 )

cc @beckermr


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/8622718322.

@jakirkham jakirkham marked this pull request as draft April 9, 2024 22:09
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM (though not a maintainer here) - thanks for doing this!

(not sure why it's a draft...)

@jakirkham
Copy link
Member Author

Thanks Axel! 🙏

Was looking for reviews from folks like yourself 🙂

@dalcinl
Copy link
Contributor

dalcinl commented Apr 10, 2024

@jakirkham Looks like this one is ready. Should we merge?

@jakirkham jakirkham marked this pull request as ready for review April 10, 2024 15:40
@jakirkham
Copy link
Member Author

If it looks good, please feel free to merge

@leofang leofang merged commit 5bfd505 into conda-forge:main Apr 10, 2024
10 checks passed
@jakirkham jakirkham deleted the use_stdlib_c branch April 10, 2024 17:45
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants