Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python_bin in SRC_DIR #744

Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Nov 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12055532250. Examine the logs at this URL for more detail.

@xhochy
Copy link
Member Author

xhochy commented Nov 26, 2024

Looks like the move to alma9 breaks the yum requirements:

+ /usr/bin/sudo -n yum install -y libX11 libxcb libxau
AlmaLinux 9 - AppStream                         9.0 MB/s | 8.6 MB     00:00    
AlmaLinux 9 - BaseOS                            3.3 MB/s | 3.4 MB     00:01    
AlmaLinux 9 - Extras                             19 kB/s |  13 kB     00:00    
No match for argument: libxau
  * Maybe you meant: libXau
Error: Unable to find a match: libxau

@xhochy
Copy link
Member Author

xhochy commented Nov 26, 2024

@h-vetinari @beckermr I saw somewhere in the past days you two chatting about python_min and downstream. I sadly don't remember/find where/what. The error here is related to downstream and python_min, so I wanted to ping you in case you have an idea on how to fix it.

@xhochy
Copy link
Member Author

xhochy commented Nov 26, 2024

To avoid looking into CI logs: It fails in a downstream test for setuptools which wants to install python=3.9 instead of the one built in this recipe.

@beckermr
Copy link
Member

beckermr commented Nov 26, 2024

Yes the issue is that a downstream test might be a noarch: python package which by default is tested only on python_min. There are two fixes, depending on what is more important.

  1. Constrain the downstream tests in the upstream package to only run on python_min.
  2. Remove the python_min requirement from the downstream package's test requirements.

More or less, you prefer 1 when testing the downstream package on python_min is the most important thing. You prefer 2 when testing all python versions of the upstream package with the downstream package is the most important thing.

In this case, I suspect 2 is the right choice.

@beckermr
Copy link
Member

I am going to add this text to our docs for posterity.

@beckermr
Copy link
Member

@xhochy
Copy link
Member Author

xhochy commented Nov 26, 2024

Thank you! Fix is then here: conda-forge/setuptools-feedstock#371

@xhochy xhochy marked this pull request as ready for review November 27, 2024 08:44
@xhochy xhochy mentioned this pull request Nov 27, 2024
5 tasks
@isuruf
Copy link
Member

isuruf commented Nov 27, 2024

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label Nov 27, 2024
@conda-forge-admin conda-forge-admin merged commit 245770e into conda-forge:main Nov 27, 2024
25 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants