feat: Add plothist #27414
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| {% set name = "plothist" %} | ||
| {% set version = "1.2.5" %} | ||
|
|
||
| package: | ||
| name: {{ name|lower }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/plothist-{{ version }}.tar.gz | ||
| sha256: b4606d9ff7db3cc1a7f6f5d5440fd959e1d1292818910cc0d142b23e65e4de76 | ||
|
|
||
| build: | ||
| entry_points: | ||
| - install_latin_modern_fonts = plothist.scripts.install_latin_modern_fonts:install_latin_modern_fonts | ||
| noarch: python | ||
| script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
| number: 0 | ||
|
|
||
| requirements: | ||
| host: | ||
| - python >=3.7 | ||
| - flit-core >=3.2,<4 | ||
| - pip | ||
| run: | ||
| - python >=3.7 | ||
| - boost-histogram >=1.4.0,<1.5.dev0 | ||
| - numpy >=1.14.5 | ||
| - matplotlib-base >=3.0 | ||
| - pyyaml >=5.3.1 | ||
| - scipy >=1.6.0 | ||
| # Needed for install_latin_modern_fonts | ||
| - wget | ||
| - unzip | ||
|
Comment on lines
+31
to
+33
There was a problem hiding this comment. c.f. cyrraz/plothist#175 There was a problem hiding this comment. Should we wait for cyrraz/plothist#176 to be merged and a new small release? Or is it ok to be merged now? There was a problem hiding this comment. Conda-forge will create new release PRs automatically on the There was a problem hiding this comment. I am not familiar with the workflow of conda-forge. We created the new release https://github.com/cyrraz/plothist/releases/tag/v1.2.6, but not PR got automatically created in https://github.com/conda-forge/plothist-feedstock. Should I do what the readme says (fork + PR) or did we miss a setup that would automatically create the PR? There was a problem hiding this comment. Once it is on PyPI a PR should get generated a few hours later. It takes some time for the checking scripts to loop through, but there will be a PR open within the next 24 hours. There was a problem hiding this comment. Thank you, it worked perfectly conda-forge/plothist-feedstock#1 😄 |
||
|
|
||
| test: | ||
| imports: | ||
| - plothist | ||
| commands: | ||
| - pip check | ||
| # On macOS need /Users/<username>/Library/Fonts | ||
| - install_latin_modern_fonts # [linux] | ||
| requires: | ||
| - pip | ||
|
|
||
| about: | ||
| home: https://github.com/cyrraz/plothist | ||
| summary: Plot histograms in a scalable way and a beautiful style. | ||
| license: BSD-3-Clause | ||
| license_file: LICENSE | ||
| doc_url: https://plothist.readthedocs.io/ | ||
| dev_url: https://github.com/cyrraz/plothist | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - 0ctagon | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing on Windows for
noarchPython projects is allowed given what I've been told by conda-forge core people in the past so this is fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case the package won't be installable on Windows. If that is by design, we can merge this. However, it does seem like this package can be OS-noarch. See https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-packages-with-os-specific-dependencies for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf In that case, given #27414 (comment) maybe we can wait for @0ctagon to make a patch release with cyrraz/plothist#176 merged and then we can have that patch release be the one that generates the feedstock (so we'd update the version and sha256).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B/c there is a patch already we can:
I don't think it is worth making it OS-noarch b/c the fix is there already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf I'm find with this suggestion. There should be a new patch release on PyPI before the end of the week so it would only be broken on Windows for a few days.