Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add servicex client #27997

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/servicex/meta.yaml) and found some lint.

Here's what I've got...

For recipes/servicex/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/servicex/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

conda-forge/func-adl-feedstock#9 should fix the current errors.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please restart ci

@matthewfeickert
Copy link
Member Author

(Having to force push as the CI lost the branch on restart through the bot)

Comment on lines 12 to 13
build:
skip: true # [py<38]
Copy link
Member Author

@matthewfeickert matthewfeickert Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a noarch package in reality, but I believe that to use to use selectors like # [py<310] you can't use them with noarch. This is what grayskull generated too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the selectors, installing those packages in py>39/py310 is not a problem.

@matthewfeickert matthewfeickert marked this pull request as ready for review October 25, 2024 09:26
@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review!

* c.f. https://github.com/ssl-hep/ServiceX_frontend
* Recipe generated with grayskull via 'grayskull pypi servicex'
  and then edited to add additional information.
Comment on lines +38 to +39
- importlib-metadata # python <= 3.9
- typing_extensions # python <= 3.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to keep the comments! Reminder to remove when we bump the min Python.

@ocefpaf ocefpaf merged commit e934daf into conda-forge:main Oct 25, 2024
5 of 7 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-servicex branch October 25, 2024 11:54
@matthewfeickert
Copy link
Member Author

Thanks for the help and fast merge @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants