-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add servicex client #27997
feat: Add servicex client #27997
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/servicex/meta.yaml:
|
bb9940f
to
da68daa
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
conda-forge/func-adl-feedstock#9 should fix the current errors. |
@conda-forge-admin, please restart ci |
da68daa
to
dd9f3f6
Compare
(Having to force push as the CI lost the branch on restart through the bot) |
recipes/servicex/meta.yaml
Outdated
build: | ||
skip: true # [py<38] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a noarch
package in reality, but I believe that to use to use selectors like # [py<310]
you can't use them with noarch
. This is what grayskull
generated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the selectors, installing those packages in py>39/py310 is not a problem.
@conda-forge/help-python, ready for review! |
* c.f. https://github.com/ssl-hep/ServiceX_frontend * Recipe generated with grayskull via 'grayskull pypi servicex' and then edited to add additional information.
dd9f3f6
to
e3c53bf
Compare
- importlib-metadata # python <= 3.9 | ||
- typing_extensions # python <= 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to keep the comments! Reminder to remove when we bump the min Python.
Thanks for the help and fast merge @ocefpaf! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).