API for customizing the conda base environment. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to rebase / merge the contents of |
ssurbhi560
force-pushed
the
customize-base-env-api
branch
from
f45dd8f to
23d2104
Compare
ssurbhi560
force-pushed
the
customize-base-env-api
branch
from
23d2104 to
a9d8597
Compare
jaimergp
reviewed
Nov 1, 2022
condacolab.py
Outdated
Comment on lines
25
to
36
| from IPython.display import display | ||
|
|
||
| from IPython import get_ipython | ||
|
|
||
| try: | ||
| from ruamel.yaml import YAML | ||
| from ruamel.yaml.comments import CommentedMap | ||
| except ImportError as e: | ||
| raise RuntimeError("Could not find ruamel.yaml, plese install using `!pip install ruamel.yaml`!") from e | ||
|
|
||
| try: | ||
| import ipywidgets as widgets |
There was a problem hiding this comment.
Two things:
- Sort dependencies and separate stdlib from 3rd party
- Add 3rd party packages to
pyproject.tomldependencies to ensure everything is available in case Google changes the bundled packages.
There was a problem hiding this comment.
Did it here: #41! :)
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
|
Also, make sure we don't overwrite the original |
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 7, 2022
condacolab.py
Outdated
| yaml.dump(env_details, f) | ||
|
|
||
| _run_subprocess( | ||
| [f"{prefix}/bin/python", "-m", "conda_env", "update", "-n", "base", "-f", environment_file_path, *extra_conda_args], |
There was a problem hiding this comment.
Let's pass conda_exe from the calling function to this one so we can use mamba if available. That should reduce solver times.
Suggested change
| [f"{prefix}/bin/python", "-m", "conda_env", "update", "-n", "base", "-f", environment_file_path, *extra_conda_args], | |
| [conda_exe, "env", "update", "-n", "base", "-f", environment_file_path, *extra_conda_args], |
Open
|
Hi, just stumbled on the nice blog post by @ssurbhi560 and came looking for the new features :) |
dlmiles
reviewed
May 20, 2024
| @@ -297,6 +297,8 @@ def install_from_url( | |||
| "pip_task.log" | |||
| ) | |||
|
|
|||
| print("📦 Updating enviornment using YAML file...") | |||
There was a problem hiding this comment.
print("📦 Updating environment using YAML file...")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we provide an API for users to customize the conda base environment during the condacolab's installation. Users will have the following options to specify:
environment_file- This can be a URL or path to an environment.yaml file.specs- This is a list of additional specifications (packages) to install.python_version- Python version to use in the conda base environment, eg. "3.9".channels- Comma-separated list of channels to use in the conda base environment.pip_args- List of additional packages to be installed using pipextra_conda_args- This is a list of any extra conda arguments used during the installation.You can check this example notebook demonstrating the new feature here.
Status