-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stdlib being recognized in variant hash inputs #5195
Conversation
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
|
This function is used downstream in conda-forge's conda-smithy, so let's test against this explicitly, too. Signed-off-by: Marcel Bargull <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for tackling this! 🙏
The changes LGTM.
Thank you all! :) Given that this is a straightforward and well-scoped patch for functionality that isn't in use anywhere yet, and arguably a bugfix for a faulty implementation in #4999, would you consider a backport to 24.1.x? The reason I'm asking is because a lot of work in conda-forge is backed up on this (w.r.t. moving to glibc 2.17 resp. macOS 10.13, both of which are getting more pressing every week), and so it would be great to reduce time spent waiting for procedure, and hopefully reduce the hair-on-fire likelihood later on this year by starting some very long-running things (like migrating all our compiled recipes to contain Independently of your choice for how to handle this in conda-build itself, I'll also propose this for backporting on the conda-forge feedstock, which would be "good enough" for unblocking work in conda-forge/conda-forge.github.io#1844, though of course a new patch version would be preferable. |
Description
Fixes gh-5190.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?