Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for LIEF=0.14 #5228

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Add compatibility for LIEF=0.14 #5228

merged 5 commits into from
Mar 11, 2024

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Mar 11, 2024 •
edited
Loading

Description

Add compatibility for LIEF=0.14
Fixes gh-5227.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@mbargull
Add compatibility for LIEF=0.14
c3181f8 
Signed-off-by: Marcel Bargull <[email protected]>
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 11, 2024
@mbargull mbargull mentioned this pull request Mar 11, 2024
Open
@mbargull mbargull modified the milestone: 24.3.x Mar 11, 2024
@mbargull
Copy link
Member Author

@conda/builds-tools, I've just added the corresponding issue to the 24.3.x milestone real quick so we have conda-build ready for whenever we make py-lief>=0.14 packages widely available.

@jezdez
Copy link
Member

jezdez commented Mar 11, 2024

@mbargull @beeankha and I are about to cut the release branch for 24.3.x to kickoff the release process, do you plan to work on the compatibility today? Since in case not, this is something we'll have to do in a minor release.

@mbargull
Copy link
Member Author

@beeankha and I are about to cut the release branch for 24.3.x to kickoff the release process

Haha, I just sent her a message asking if you have concrete plans 🤣 .

do you plan to work on the compatibility today?

Yes, the code changes are likely ready already.
I'm just waiting for the CI to go through (current failures on Windows are unrelated CI setup flukes), will then revert cb5df71 and then this should be ready to go in.

@mbargull mbargull marked this pull request as ready for review March 11, 2024 17:11
@mbargull mbargull requested a review from a team as a code owner March 11, 2024 17:11
kenodegard
kenodegard approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming constant renaming (lief.PE.HEADER_CHARACTERISTICS → lief.PE.Header.CHARACTERISTICS and lief.EXE_FORMATS → lief.Binary.FORMATS) and removal of lief.Binary.name (using str(file) instead)

@mbargull mbargull merged commit 4bc2fd8 into conda:main Mar 11, 2024
26 checks passed
@beeankha beeankha mentioned this pull request Mar 12, 2024
Closed
32 tasks
@mxschmitt mxschmitt mentioned this pull request Apr 2, 2024
Closed
mbargull added a commit to mbargull/conda-build that referenced this pull request May 21, 2024
@mbargull
Fix excessive memory use in inspect_linkages_lief
5e460af 
introduced in condagh-5228 which replaced binary.name with str(file).
The former returns the path to the binary whereas the latter returns the
contents of the parsed binary, naturally causing high memory usage.
That semantic change was unintended (misread upstream changes).
Since binary's path is no longer part of the object, pass it separately.

Signed-off-by: Marcel Bargull <[email protected]>
@mbargull mbargull mentioned this pull request May 21, 2024
Merged
3 tasks
kenodegard pushed a commit that referenced this pull request May 22, 2024
@mbargull
Fix excessive memory use in inspect_linkages_lief (#5348)
515aa8f 
* Fix excessive memory use in inspect_linkages_lief
introduced in gh-5228 which replaced binary.name with str(file).
The former returns the path to the binary whereas the latter returns the
contents of the parsed binary, naturally causing high memory usage.
That semantic change was unintended (misread upstream changes).
Since binary's path is no longer part of the object, pass it separately.

* Use consistent var name in inspect_linkages_lief to avoid variable shadowing.

* Remove redundant get_uniqueness_key call

---------

Signed-off-by: Marcel Bargull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenodegard kenodegard kenodegard approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda-build not yet compatible with LIEF 0.14 API changes
4 participants
@mbargull @jezdez @kenodegard @conda-bot