feat: Add rattler-index-s3
#1012
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not sure if this is ready for review but Im wondering if it makes sense to use the |
|
@baszalmstra this is not ready to review yet. Thanks for the hint on opendal, I'll check it out later. #1008 is ready to review and this PR just contains the changes from #1008 as well. |
pavelzw
reviewed
Jan 13, 2025
Comment on lines
+54
to
+58
| let default_filter = if opt.verbose { | ||
| LevelFilter::DEBUG | ||
| } else { | ||
| LevelFilter::INFO | ||
| }; |
There was a problem hiding this comment.
we should IMO use clap_verbosity_flag here
There was a problem hiding this comment.
I copied this from rattler-bin, but I agree with you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description