-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LP-3339: Fix --cku
description for kafka cluster update
#2379
Open
brianstrauch
wants to merge
6
commits into
main
Choose a base branch
from
fix-shrink-cku
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgagniere
previously approved these changes
Oct 27, 2023
tyffani
previously approved these changes
Oct 27, 2023
tim-elhajj
previously approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, still no word on when to merge. I have a doc PR, too. https://github.com/confluentinc/docs-cloud/pull/3014
brianstrauch
dismissed stale reviews from tim-elhajj, sgagniere, and tyffani
via
November 30, 2023 19:34
8a7811e
@brianstrauch is this PR still in progress? |
Yes, let me bump the relevant team |
linouk23
changed the title
Fix
LP-3339: Fix May 24, 2024
--cku
description for kafka cluster update
--cku
description for kafka cluster update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What
Clusters no longer need to be shrunk one CKU at a time.
Test & Review
Updated integration test