Migrate to Go Modules

[eran-levy]

fixes #551

had CLA issues with PR #553 that was created 2 years ago so created this new PR to make sure its clear

[eran-levy]

@edenhill @jeffwidman this is the new PR with all code changes for go modules migration.

Had issues with PR #553 branch which was 2 years ago - #553 (comment)

[jeffwidman]

I haven't tested locally, but looks reasonable to me. Thanks for keeping this moving.

[jeffwidman]

How is this related to go modules?

[eran-levy]

Not very related just to ignore internal goland IDE and mac folders to eliminate mistakes, I can remove them if its not according to the standards, do you want me to revert this one?

[edenhill]

This is great stuff! Let me know when it is ready to be merged.

[jeffwidman]

@edenhill I think that's up to you? It looks ready to me unless you want the .gitignore change dropped... I don't feel strongly either way, and besides, it's your project, not mine. 😀

[eran-levy]

@jeffwidman @edenhill we can consider this PR as done, otherwise you would like me to make any other changes?

[edenhill]

Great stuff!

[edenhill]

Thanks for doing this, @eran-levy !
And thanks for the review @jeffwidman !

[jeffwidman]

Thanks @edenhill!

@eran-levy btw, I just realized that you only added a go.mod but not a go.sum file... is there a reason for that? While it's functional as-is, typically the go.sum file is committed for additional security.

[eran-levy]

@jeffwidman you're correct, but the go.mod under the root folder doesnt include any lib dependencies so that why go.sum is missing. In the rest of the modules such as: examples/ there is a dependency so thats why go.sum exists.

So seems fine to me, no changes required

[jeffwidman]

Oh that makes sense. Thanks!