Check KAFKA_LISTENER_SECURITY_PROTOCOL_MAP for SSL #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach adds SSL configuration if the advertised listeners includes the string `SSL://`. But in a configuration such as ``` KAFKA_ADVERTISED_LISTENERS: CLIENTS://mykafka.host:9093 KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: CLIENTS:SSL ``` The ssl configuration is not added, even though the protocol `CLIENTS` does map to `SSL` Tweaking this configuration script so that it looks in both `KAFKA_ADVERTISED_LISTENERS` and `KAFKA_LISTENER_SECURITY_PROTOCOL_MAP` for usage of SSL.
|
|
soondenana
approved these changes
Oct 17, 2024
| @@ -84,7 +84,9 @@ then | |||
| fi | |||
|
|
|||
| # Set if ADVERTISED_LISTENERS has SSL:// or SASL_SSL:// endpoints. | |||
| if [[ -n "${KAFKA_ADVERTISED_LISTENERS-}" ]] && [[ $KAFKA_ADVERTISED_LISTENERS == *"SSL://"* ]] | |||
| # Or if the LISTENER_SECURITY_PROTOCOL_MAP includes SSL | |||
| if ([[ -n "${KAFKA_ADVERTISED_LISTENERS-}" ]] && [[ $KAFKA_ADVERTISED_LISTENERS == *"SSL://"* ]]) || | |||
There was a problem hiding this comment.
does this work with lower case, for example Sasl_ssl
There was a problem hiding this comment.
No. Is that something that people would do? I don't think the current code covers that case either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach adds SSL configuration if the advertised listeners includes the string
SSL://.But in a configuration such as
The ssl configuration is not added, even though the protocol
CLIENTSdoes map toSSLTweaking this configuration script so that it looks in both
KAFKA_ADVERTISED_LISTENERSandKAFKA_LISTENER_SECURITY_PROTOCOL_MAPfor usage of SSL.