Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KREST-11860 CNC-397: unpin jetty to use the version defined in common #413

Merged
merged 1 commit into from
Oct 11, 2023
Merged

KREST-11860 CNC-397: unpin jetty to use the version defined in common #413

merged 1 commit into from
Oct 11, 2023

Conversation

janjwerner-confluent
Copy link
Member

@janjwerner-confluent janjwerner-confluent commented Oct 9, 2023 •
edited
Loading

Jetty version is defined in common. Unpin the version here and use the one defined globally

@atlantis-infrasec-infra
Copy link 

Error: This repo is not allowlisted for Atlantis.

@cla-assistant
Copy link

cla-assistant bot commented Oct 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@janjwerner-confluent janjwerner-confluent requested a review from a team October 9, 2023 18:09
@janjwerner-confluent janjwerner-confluent changed the title unpin jetty to use the version defined in common CNC-397: unpin jetty to use the version defined in common Oct 10, 2023
@msn-tldr
Copy link
Member

@janjwerner-confluent can you share where in common's is the jetty-version defined?

@janjwerner-confluent
Copy link
Member Author

@msn-tldr it's here:
https://github.com/confluentinc/common/blob/16bbfe8894a51c70c26984d6fb72f9c2cf124831/pom.xml#L61

@msn-tldr
Copy link
Member

@janjwerner-confluent Approving, lgtm.
I see the jetty-version is not coming from common in master. Can you pint merge ur PR from 6.0.x -> master?

@msn-tldr msn-tldr mentioned this pull request Oct 11, 2023
Closed
@janjwerner-confluent janjwerner-confluent merged commit 8caeb66 into 6.0.x Oct 11, 2023
@janjwerner-confluent janjwerner-confluent deleted the unpin-jetty branch October 11, 2023 16:12
@janjwerner-confluent janjwerner-confluent changed the title CNC-397: unpin jetty to use the version defined in common KREST-11860 CNC-397: unpin jetty to use the version defined in common Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msn-tldr msn-tldr msn-tldr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjwerner-confluent @msn-tldr