Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to use CommandResult as a parent class #258

Closed
Sweetchuck opened this issue Jan 4, 2022 · 0 comments
Closed

Difficult to use CommandResult as a parent class #258

Sweetchuck opened this issue Jan 4, 2022 · 0 comments

Comments

@Sweetchuck
Copy link
Contributor

Steps to reproduce

<?php
class MyCommandResult extends \Consolidation\AnnotatedCommand\CommandResult
{
}
<?php
class RoboFile extends \Robo\Tasks
{
    /**
     * @command foo
     */
    public function foo(): MyCommandResult
    {
        $myData = [];

        return MyCommandResult::data($myData);
    }
}

Expected behavior

Use new static(); instead of new self();

return new self(null, $exitCode);

Actual behavior

Error message:

Return value is expected to be 'MyCommandResult', 'Consolidation\AnnotatedCommand\CommandResult' returned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant