Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #234. Less parsing by ignoring Traits and IO.php #237

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Sep 11, 2021

Disposition

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Summary

Avoid repeated parsing of methods unlikely to contain annotations.

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #237 (1550126) into main (e99c65c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #237   +/-   ##
=========================================
  Coverage     89.76%   89.77%           
- Complexity      731      733    +2     
=========================================
  Files            45       45           
  Lines          1896     1897    +1     
=========================================
+ Hits           1702     1703    +1     
  Misses          194      194           
Impacted Files Coverage Δ
src/AnnotatedCommandFactory.php 96.37% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99c65c...1550126. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants