Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/4.x inherited methods #277

Merged

Conversation

DieterHolvoet
Copy link
Contributor

Disposition

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes

Summary

This fixes the issue raised in #273. Same PR as #276, but for the 4.x branch.

@DieterHolvoet DieterHolvoet changed the base branch from 5.x to 4.x November 2, 2022 09:02
@greg-1-anderson
Copy link
Member

Looks great. This will break Drush again, so let's coordinate there a bit (I will do this) before merging here.

@DieterHolvoet
Copy link
Contributor Author

As far as we know this issue only affected the WXT profile and I already proposed an alternative fix: https://www.drupal.org/project/wxt/issues/3315821

@greg-1-anderson
Copy link
Member

I prefer to keep the prohibition against extending command classes active in Drush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants