Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant create a semver file using the SemVer task #959

Closed
pixelbrackets opened this issue Jul 23, 2020 · 0 comments
Closed

Cant create a semver file using the SemVer task #959

pixelbrackets opened this issue Jul 23, 2020 · 0 comments

Comments

@pixelbrackets
Copy link
Contributor

pixelbrackets commented Jul 23, 2020 •
edited
Loading

Steps to reproduce

Run the semver task for the first time.

Expected behavior

Create the file with the preset format.

Actual behavior

Throws an exception that the task can not create the file. When the file was created manually before, then the task is successful.

System Configuration

Ubuntu 20, PHP 7.2
pixelbrackets added a commit to pixelbrackets/robo that referenced this issue Jul 23, 2020
@pixelbrackets
[BUGFIX] Remove redundant check preventing file writes
cb0e902 
Remove the check that a given filename is writetable,
since this requires the file to exist beforehand.

We dont expect the file to exist however. Therefore this
check should not be made or create a file if failing.

Since this check is included in file_put_contents anyway
we may remove the check safely.

Closes consolidation#959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelbrackets