Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #936: Github access_token via query parameter is deprecated. #943

Merged
merged 1 commit into from
May 22, 2020

Conversation

danepowell
Copy link
Contributor

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes
  • Adds or fixes documentation

Summary

See #936: Github has deprecated the usage of access_token via a query parameter as Robo currently uses for Github requests. You should use an authorization header with the access token instead.

This is untested but I'm pretty sure should work.

@greg-1-anderson greg-1-anderson merged commit 5d5e6d7 into consolidation:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants