fixes #951: Updated grasmash/yaml-expander dependency

[romanmartushev]

Overview

This pull request:

• Fixes a bug

Summary

Updated grasmash/yaml-expander dependency to version that supports symfony/yaml v5

[romanmartushev]

closes #951

[alsar]

@romanmartushev why was this closed?

[romanmartushev]

The pipeline did not pass and I was not going to up the coverage just for a dependency change.

[greg-1-anderson]

I haven't looked at this. In general, I am in favor of major version updates of dependencies if it can be done in a backwards-compatible way. If anyone wants to continue with this investigation, please also use the | operator so that existing supported versions continue to work. It is not necessary to support every intermediate version.

[alsar]

@greg-1-anderson grasmash/yaml-expander v3.0 has a constraint "symfony/yaml": "^4 | ^5". Robo requires v4.4.8 as a minumim for Symfony components. So there should not be any backwards incompatibility with bumping the version for grasmash/yaml-expander.

[greg-1-anderson]

gasmash/yaml-expander itself may have introduced bc-breaking changes in 2.x or 3.x. I have not investigated this.

[alsar]

@greg-1-anderson according to changelogs there are none. At least they shouldn't affect Robo.
v2 had internal refactoring and v3 dropped support for php 5.4 and Symfony 2.

BTW, I don't see that this package is used anywhere in the codebase.

[greg-1-anderson]

As I said above, I am in favor of major version upgrades of dependencies if there are no bc breaks because of it. This PR would be acceptable with passing tests. If grasmash/yaml-expander really is not used in this repository, then a PR that removed it as a dependency (and has passing tests) would also be acceptable.

It is plausible that grasmash/yaml-expander is no longer used here. Robo primarily uses consolidation/config for configuration access, which requires grasmash/expander instead.