Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No download if current version is greater than latest release. #18

Merged
merged 1 commit into from
Feb 9, 2022
Merged

No download if current version is greater than latest release. #18

merged 1 commit into from
Feb 9, 2022

Conversation

kporras07
Copy link
Collaborator

@kporras07 kporras07 commented Feb 9, 2022 •
edited
Loading

If current version is greater than latest release then self:update should not try to update.

Example:

  • Current = 3.0.6-dev
  • Latest = 3.0.5
  • Current behavior: update (why?)
  • New behavior: No available updates message.

@kporras07 kporras07 force-pushed the no-download-if-current-greater branch from 92cf739 to ebbeece Compare February 9, 2022 22:27
@kporras07 kporras07 marked this pull request as ready for review February 9, 2022 22:30
greg-1-anderson
greg-1-anderson approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kporras07 kporras07 merged commit 8a64bdd into main Feb 9, 2022
@kporras07 kporras07 deleted the no-download-if-current-greater branch February 9, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-1-anderson greg-1-anderson greg-1-anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kporras07 @greg-1-anderson