Fix error code on wrong snapshot ID or topology #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change LGTM. I think we also need to add one more here, which is |
When CreateVolumeRequest finds out that a volume to be created already exists and it was restored from a *different* snapshot or is available at different topology than requested, it should return ALREADY_EXISTS.
jsafrane
force-pushed
the
fix-content-source-error
branch
from
968bbe4 to
116df61
Compare
|
Added |
jsafrane
changed the title
xing-yang
reviewed
Feb 18, 2020
spec.md
Outdated
| @@ -1119,7 +1119,7 @@ The CO MUST implement the specified error recovery behavior when it encounters t | |||
| |-----------|-----------|-------------|-------------------| | |||
| | Source incompatible or not supported | 3 INVALID_ARGUMENT | Besides the general cases, this code MUST also be used to indicate when plugin supporting CREATE_DELETE_VOLUME cannot create a volume from the requested source (`SnapshotSource` or `VolumeSource`). Failure MAY be caused by not supporting the source (CO SHOULD NOT have provided that source) or incompatibility between `parameters` from the source and the ones requested for the new volume. More human-readable information SHOULD be provided in the gRPC `status.message` field if the problem is the source. | On source related issues, caller MUST use different parameters, a different source, or no source at all. | | |||
| | Source does not exist | 5 NOT_FOUND | Indicates that the specified source does not exist. | Caller MUST verify that the `volume_content_source` is correct, the source is accessible, and has not been deleted before retrying with exponential back off. | | |||
| | Volume already exists but is incompatible | 6 ALREADY_EXISTS | Indicates that a volume corresponding to the specified volume `name` already exists but is incompatible with the specified `capacity_range`, `volume_capabilities` or `parameters`. | Caller MUST fix the arguments or use a different `name` before retrying. | | |||
| | Volume already exists but is incompatible | 6 ALREADY_EXISTS | Indicates that a volume corresponding to the specified volume `name` already exists but is incompatible with the specified `capacity_range`, `volume_capabilities`, `parameters`, `accessibility_requirements` or `content_source`. | Caller MUST fix the arguments or use a different `name` before retrying. | | |||
There was a problem hiding this comment.
s/content_source/volume_content_source
jsafrane
force-pushed
the
fix-content-source-error
branch
from
116df61 to
a82f700
Compare
|
lgtm |
jdef
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one more reason to return
ALREADY_EXISTSfromCreateVolumeRequest: the volume to be created already exists, but it was restored from a different snapshot than requestedThis follows all other
ALREADY_EXISTScases - the volume already exists, but it's something else than CO requested.