Fixes to tests to make cargo clippy succeed #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ismo Puustinen <[email protected]>
Signed-off-by: Ismo Puustinen <[email protected]>
ipuustin
changed the title
jprendes
reviewed
Jun 8, 2023
| @@ -219,12 +219,9 @@ mod noptests { | |||
| fn test_nop_kill_sigkill() -> Result<(), Error> { | |||
| let nop = Arc::new(Nop::new("".to_string(), None)); | |||
There was a problem hiding this comment.
IIUC, you don't need this Arc either.
Same for all the other ones in the PR (inc. the wasi one).
There was a problem hiding this comment.
Hmm, I think you are right. Removed the Arc wrapping from tests now.
| @@ -372,6 +371,8 @@ mod wasitest { | |||
| let output = read_to_string(dir.path().join("stdout"))?; | |||
| assert_eq!(output, "hello world\n"); | |||
|
|
|||
| wasi.delete()?; | |||
There was a problem hiding this comment.
Would it make sense to have as part of trait Drop?
There was a problem hiding this comment.
I'm not sure! It would look nicer but we would lose the error handling if delete() fails. Also it would be a breaking change in the API. I would maybe not add that change into this PR but think about it later.
Mossaka
approved these changes
Jun 8, 2023
Signed-off-by: Ismo Puustinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
delete()to Wasmtime tests. Also clean up the code a little to makecargo clippysucceed.