Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update youki to the latest main branch and oci-spec to 0.6.1. #139

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jun 12, 2023

Since youki now uses thiserror instead of anyhow, this PR also updates the containerd-shim-wasmedge to properly map the error.

@ipuustin
Copy link
Contributor

#130 has the required fixes to runwasi for updating youki version... let's merge that first?

@Mossaka
Copy link
Member Author

Mossaka commented Jun 12, 2023

Sure!

Since youki now uses thiserror instead of anyhow, this PR
also updates the containerd-shim-wasmedge to properly map
the error.

Signed-off-by: jiaxiao zhou <[email protected]>
@Mossaka Mossaka requested a review from ipuustin June 13, 2023 23:54
Copy link
Contributor

@ipuustin ipuustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It seems that youki 0.1.0 release should happen soon, we can use an official release when it's out.

@Mossaka Mossaka merged commit 62c6b7a into containerd:main Jun 14, 2023
@Mossaka Mossaka deleted the oci-0.6.1 branch June 14, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants