Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add make deps to release CI #186

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jul 19, 2023

No description provided.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, beyond CI failing, I'm not a fan of this since its encoding ubuntu/debian specific things into the makefile.
It'd be fine to include this in script somewhere, though.

@Mossaka Mossaka closed this Jul 19, 2023
@Mossaka Mossaka reopened this Jul 19, 2023
@Mossaka Mossaka closed this Jul 19, 2023
@Mossaka Mossaka reopened this Jul 19, 2023
@Mossaka
Copy link
Member Author

Mossaka commented Jul 19, 2023

okay all of these CI failures were due to a cache. After I deleted the cache, the CI succeed. I am going to rollback to the previous commit.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 234d11e into containerd:main Jul 19, 2023
@Mossaka Mossaka deleted the release-ci branch July 19, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants