Support passing named pipes in stdio #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
reviewed
Aug 25, 2023
jprendes
approved these changes
Aug 25, 2023
jsturtevant
force-pushed
the
support-pipes-windows
branch
from
92f8d3e to
823a067
Compare
|
Thanks for fixing this @jsturtevant . |
jprendes
reviewed
Aug 25, 2023
jprendes
approved these changes
Aug 25, 2023
Signed-off-by: James Sturtevant <[email protected]> Signed-off-by: James Sturtevant <[email protected]> Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
support-pipes-windows
branch
from
823a067 to
b6f2b1a
Compare
Mossaka
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerd passes STDIO as named pipes on windows. The stdio implementation with
libc::dup2([f.as](http://f.as/)_raw_fd(), $fd) }would error withinvalid handle was specified.This checks if it starts with the standard named_pipe path and adds the appropriate
openoptions.