Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge both existing run_wasi_test implementations #279

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Merge both existing run_wasi_test implementations #279

merged 1 commit into from
Aug 25, 2023

Conversation

jprendes
Copy link
Collaborator

Small cleanup deduplicating code.

@jprendes jprendes requested a review from Mossaka August 25, 2023 21:43
Mossaka
Mossaka previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love the use of generics

@jsturtevant
Copy link
Contributor

nice, this is similar to what I tried in #220 but cleaner after the clean up to the instance and engine traits.

This function could be used to help with #111 as well.

@jprendes
Copy link
Collaborator Author

jprendes commented Aug 25, 2023 •
edited
Loading

Love the use of generics

Otherwise I would have had to move tempfile to a full dependency instead of a dev-dependency :-)

@jprendes
Copy link
Collaborator Author

green CI now :-)

@Mossaka Mossaka merged commit 8b07a7a into containerd:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossaka Mossaka Mossaka approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprendes @jsturtevant @Mossaka