Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wasmer doc #302

Merged
merged 1 commit into from
Sep 13, 2023
Merged

add wasmer doc #302

merged 1 commit into from
Sep 13, 2023

Conversation

dierbei
Copy link
Contributor

@dierbei dierbei commented Sep 9, 2023

add wasmer doc

Fix #301

Signed-off-by: dierbei <[email protected]>
@jsturtevant
Copy link
Contributor

are there any pre-reqs that need to be installed with wasmer? otherwise lgtm

@dierbei
Copy link
Contributor Author

dierbei commented Sep 12, 2023

are there any pre-reqs that need to be installed with wasmer? otherwise lgtm

Thanks for the tip, I seem to have forgotten about this.

I decided to go ahead and test it, without the wasmer installed.

@dierbei
Copy link
Contributor Author

dierbei commented Sep 13, 2023

@jsturtevant No other dependencies are required after testing.

@jsturtevant
Copy link
Contributor

LGTM

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes
Copy link
Collaborator

@devigned PTAL

@jprendes jprendes closed this Sep 13, 2023
@jprendes jprendes reopened this Sep 13, 2023
@Mossaka Mossaka merged commit f9f3d22 into containerd:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for wasmer
4 participants