Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add published version of wasm-test-modules dep #373

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Oct 30, 2023

In cargo, it is possible to specify a local path and a register version for one dep (see https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations).

What this means for us is that we can keep using local containerd-shim-wasm-test-modules for development. At the same time, when we do cargo publish, it will resolve to use the remote version of containerd-shim-wasm-test-containers from crates.io.

@jsturtevant
Copy link
Contributor

LGTM

@Mossaka Mossaka merged commit 4037b4f into containerd:main Oct 31, 2023
@Mossaka Mossaka deleted the use-specific-version branch October 31, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants