refactor(precompile): make code a bit more readable #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
force-pushed
the
refactor-compile
branch
from
45b7e67 to
4be4b59
Compare
Mossaka
requested review from
kate-goldenring and
devigned
and removed request for
kate-goldenring
this is to resolve my comments made in PR containerd#492 in an effort to make the code a bit more idiomatic and readable Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
refactor-compile
branch
from
f1377ce to
abda364
Compare
|
I just squashed my commits and invalidated the review. Could you please approve it again? @devigned |
devigned
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to resolve my comments made in PR #492 in an effort to make the code a bit more idiomatic and readable