Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*): merge build action #546

Closed
wants to merge 8 commits into from
Closed

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Apr 3, 2024

this commit merges the build step in the release action and the one in the ci action since they share a large overlap code.

the build step not only builds the binary, but signs it, and upload as action artifacts. this step is now running for every ci run, including PR and release pipeline.

Mossaka added 8 commits April 3, 2024 06:04
this commit merges the build step in the release action and
the one in the ci action since they share a large overlap code.

the build step not only builds the binary, but signs it, and
upload as action artifacts. this step is now running for every
ci run, including PR and release pipeline.

Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
@Mossaka Mossaka closed this Apr 3, 2024
@Mossaka
Copy link
Member Author

Mossaka commented Apr 3, 2024

I realized whenever we want to sensitive operations with permissions like write on the Github actions, it is always required to create the PR from branches in the upstream repo, not from forked repos. Hence I am closing this PR as it went no where and created a new one #548

@Mossaka Mossaka deleted the opt-release branch April 3, 2024 21:55
@Mossaka Mossaka restored the opt-release branch April 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant