-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(*): automate the version bump process #549
Conversation
trigger CI to execute which will then enable merging this PR. | ||
EOF | ||
- name: Make a PR | ||
run: gh pr create -B "$PR_BASE" -H "$PR_HEAD" --title "$PR_TITLE" --body "$(cat ./pr-body)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I recalled the problem with using the github actions token for opening pull requests: Jobs will not trigger on that pull request.
So you can open the PR but CI will not run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes, but I think that's fine as long as we document it in the release.md something like "you need to close the PR and re-open the PR to trigger the CIs". How does this sound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"When the PR opens, close it then reopen it. Don't ask questions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that works that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The merge-base changed after approval.
push: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right.
Looks like its going to run this on every merge to main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, a release branch would make more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the intent would be to run this on tag rather than on a branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is to run the publish
action after the version bump PR merged to main
branch
Signed-off-by: jiaxiao zhou <[email protected]>
this commit automates the version bump process to ask the bot to create a PR to bump the respective crate's version to the given one on behalf of humans. the PR created by the bot contains magic message that will be parsed by another workflow `publish` which triggers on merge to the main branch. The `publish` workflow parses the commit message to get crate, version and dry-run information to be able to publish the crate, release binary and push tags. the motivation for this commit is to further simplify the release process Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
this commit removes signing from the build CI as the release pipeline will now handle signing of the binaries downloaded using actions/download-artifact. the biggest change is that the parse script is re-write to be able to output all the necessary variables such as `runtime`, `dry_run` and more. the action-sign workflow is also modified to take an extra `path` input to replace the hard-coded `dist/bin` path Signed-off-by: jiaxiao zhou <[email protected]>
This PR may need some love, but let me first release a new version of runwasi |
Going to close this up, but feel free to refresh at some point |
this PR automates the version bump process to
ask the bot to create a PR to bump the respective
crate's version to the given one on behalf of humans.
the PR created by the bot contains magic message that
will be parsed by another workflow
publish
which triggerson merge to the main branch.
The
publish
workflow parses the commit message to getcrate, version and dry-run information to be able to
publish the crate, release binary and push tags.
the motivation for this commit is to further simplify the
release process
builds on top of #548