Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): fix another syntax error on runtime_sub #604

Merged
merged 1 commit into from
May 22, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented May 22, 2024

well, it turns out that #603 does not fix the whole issue. This PR is an attempt to address it.

@Mossaka Mossaka marked this pull request as ready for review May 22, 2024 22:57
@Mossaka Mossaka requested a review from jsturtevant May 22, 2024 22:57
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mossaka Mossaka merged commit 1a1393a into main May 22, 2024
51 checks passed
@Mossaka Mossaka deleted the fix-release-pipeline-substring2 branch May 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants