minor update for bootc-image-builder target
#367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bootc-image-builder` target depends on `bootc`, even the bootc image exists in the local storage, it still builds a new one. As we add `--local` in the podman command line, so this commit only check image in local storage, will not check remote registry. Signed-off-by: Yihuang Yu <[email protected]>
DISK_USER and DISK_GROUP are from containers#299, they are used for bib option `--chown`. However, the current variable name may cause misunderstanding, mislead people into thinking it's a user of operation system inside disk, so rename them. Also, add these 2 variables into the README. Signed-off-by: Yihuang Yu <[email protected]>
PaulYuuu
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
At first, I planned to check the remote registry together, but considering that the time to pull the image is about the same as build bootc locally, so I only check local image in this PR. the following is my first version. -bootc-image-builder: bootc
+bootc-image-builder:
+ @if ! podman image exists $(BOOTC_IMAGE); then \
+ if ! podman pull $(BOOTC_IMAGE) &> /dev/null; then \
+ $(MAKE) bootc; \
+ fi \
+ fi |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootc-image-buildertarget depends onbootc, even the bootc imageexists in the local storage, it still builds a new one. As we add
--localin the podman command line, so this commit only check image inlocal storage, will not check remote registry.
--chown. However, the current variable name may causemisunderstanding, mislead people into thinking it's a user of operation
system inside disk, so rename them.
Also, add these 2 variables into the README.
Signed-off-by: Yihuang Yu [email protected]