Use OCI Transport for embeded images to save time #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
requested review from
MichaelClifford,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
LGTM |
lmilbaum
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM. Would be useful if the work @Gregory-Pereira and I are doing can validate this change.
No reason to use containers/storage for instructlab or vllm since we are only building for embedding within a bootc image. By storing directly in OCI, we can save many minutes and lots of disk size. Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM, also - as long as it works (I haven't tested this)! |
markmc
added a commit
to markmc/ai-lab-recipes
that referenced
this pull request
May 23, 2024
Unused since containers#427 - commit 6a42054 Signed-off-by: Mark McLoughlin <[email protected]>
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to use containers/storage for instructlab or vllm since we are only building for embedding within a bootc image. By storing directly in OCI, we can save many minutes and lots of disk size.