Add target for creating disk-images #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javipolo
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
rhatdan
reviewed
May 3, 2024
training/README.md
Outdated
| @@ -18,6 +18,9 @@ In order to run accelerated AI workloads, we've prepared [bootc](https://github. | |||
| | intel | Create bootable container for Intel Habanalabs platform | | |||
| | nvidia | Create bootable container for NVidia platform | | |||
| | vllm | Containerized inference/serving engine for LLMs | | |||
| | disk-amd | Create disk image from bootable container for AMD platform | | |||
| | disk-intel | Create disk image from bootable container for Intel platform | | |||
| | disk-nvidia | Create disk image from bootable container for Nvidia platform | | |||
rhatdan
reviewed
May 3, 2024
training/README.md
Outdated
| Image builder config file is documented in [bootc-image-builder README](https://github.com/osbuild/bootc-image-builder?tab=readme-ov-file#-build-config) | ||
|
|
||
| The following image disk types are currently available: | ||
| | Image type | Target environment | |
rhatdan
reviewed
May 3, 2024
training/common/Makefile.common
Outdated
| --rm \ | ||
| -ti \ | ||
| -v $(GRAPH_ROOT):/var/lib/containers/storage \ | ||
| $(ARCH:%=--arch %) \ |
There was a problem hiding this comment.
Does this work with the ARCH removed above?
I don't think you ever want to do this? This should only be handled in the bootc section, you should not run a non native bootc-image-builder.
There was a problem hiding this comment.
Ok, removing then ... I copied most of it from the Makefile.common target that is present in the /recipes section
ai-lab-recipes/recipes/common/Makefile.common
Lines 108 to 130 in d3ba2b6
rhatdan
reviewed
May 3, 2024
| -v ./build:/output \ | ||
| -v ./build/store:/store \ | ||
| $(BOOTC_IMAGE_BUILDER) \ | ||
| $(ARCH:%=--target-arch %) \ |
There was a problem hiding this comment.
This one is GOOD. Noth the one above.
javipolo
force-pushed
the
bootc-image-builder
branch
from
ef45e95 to
871ae43
Compare
Signed-off-by: Javi Polo <[email protected]>
javipolo
force-pushed
the
bootc-image-builder
branch
from
871ae43 to
4cb23bb
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.