feat: add ports to ai-studio #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new property
Portsin the ai-studio.yaml files.This includes the ports used by the every single element within an ai application (model_service, vectordb, ai app).
It will be used by ai-studio to know which port to use when opening an app in the browser or which ports to set in the pod (also if we split the model_services and the ai app in different pods in future).
This is needed bc we now retrieve the ports info from the images exposedPorts property but this can contain ports related to the base image which is something we do not need to handle. E.g. by using the
registry.access.redhat.com/ubi9/python-39:latestbase image the port 8080 is also exposed.