Enable NVIDIA services in the bootc image #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nvidia-persistenced` and `nvidia-fabricmanager` services should be started on machines with NVIDIA devices. Fabric Manager is only needed on machines with an NVLink switch, so we patch it to start only if /dev/nvswitchctl is present. Signed-off-by: Fabien Dupont <[email protected]>
fabiendupont
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
/cc @kwozyman |
|
Looks okay to me |
rhatdan
reviewed
Jul 10, 2024
| && echo "blacklist nouveau" > /etc/modprobe.d/blacklist_nouveau.conf \ | ||
| && sed '/\[Unit\]/a ConditionPathExists = /dev/nvidia-nvswitchctl' /usr/lib/systemd/system/nvidia-fabricmanager.service \ | ||
| && ln -s /usr/lib/systemd/system/nvidia-fabricmanager.service /etc/systemd/system/multi-user.target.wants/nvidia-fabricmanager.service \ | ||
| && ln -s /usr/lib/systemd/system/nvidia-persistenced.service /etc/systemd/system/multi-user.target.wants/nvidia-persistenced.service |
There was a problem hiding this comment.
I beleive that systemctl enable ... Works in containerfile, but will merge anyways.
Could you confirm if the command works?
rhatdan
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nvidia-persistencedandnvidia-fabricmanagerservices should be started on machines with NVIDIA devices. Fabric Manager is only needed on machines with an NVLink switch, so we patch it to start only if /dev/nvswitchctl is present.