chore: add image field to define image name when building #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <[email protected]>
MichaelClifford
approved these changes
Mar 13, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
| @@ -15,11 +15,13 @@ application: | |||
| - amd64 | |||
| ports: | |||
| - 8000 | |||
| image: quay.io/redhat-et/object-detection-server | |||
There was a problem hiding this comment.
this one we haven't added to actions yet! (I'll quickly do that now)
There was a problem hiding this comment.
quay.io/redhat-et/locallm-object-detection-server:latest
sallyom
reviewed
Mar 14, 2024
| - 8501 | ||
| image: quay.io/redhat-et/object-detection-client |
There was a problem hiding this comment.
not set up in actions yet, we need to add that!
There was a problem hiding this comment.
quay.io/redhat-et/locallm-object-detection-client:latest
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
sallyom
reviewed
Mar 14, 2024
Signed-off-by: lstocchi <[email protected]>
|
@sallyom updated everything. Let me know when you have the name for the object_detection images. Thanks! |
|
LGTM - I'll upate the object-detection image names in a follow-up when I add the actions for those, let's merge this in now! |
|
As a general pattern, as we will include the recipes using a reference or a commit hash, we should not use latest for OCI image tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field
imagewhich defines the name to be used when building the container image.This is related to containers/podman-desktop-extension-ai-lab#161
@sallyom as we do not have much time to make additional customization let us know if those names are good for you as default values for the demo or you would prefer something else. Thank you!!