Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only verify MAX_ARG limit when running privileged. #391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brown
Copy link

@brown brown commented Sep 21, 2020

I've hit the MAX_ARG limit. There doesn't seem to be any reason for it when bwrap is unprivileged.

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@charmander
Copy link

I don’t see why the reason for the hardening would only apply to privileged bwrap.

@L-as
Copy link

L-as commented Dec 25, 2020

I don’t see why the reason for the hardening would only apply to privileged bwrap.

If bubblewrap has no special permissions compared to the process executing it, then it makes no sense since the process could just do what the unprivileged bubblewrap would do if it disregarded the limit.

@charmander
Copy link

What if the data bubblewrap is parsing is the problem (i.e. untrusted), not the program passing it through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants