Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.35] tag v1.35.5 #5920

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

nalind
Copy link
Member

@nalind nalind commented Jan 20, 2025

What type of PR is this?

/kind other

What this PR does / why we need it:

Tag a v1.35.5 release to incorporate the recent security update.

How to verify it

The test suite should be enough.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changes made in locations mounted using `--mount=type=bind` in RUN instructions in `buildah build` and specified to `buildah run` are now discarded.

@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Jan 20, 2025
Tag a new release to incorporate the recent security advisory, and make
a minor update to the CI configuration.

[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <[email protected]>
Allow cache mounts to be stages or additional build contexts
Integration tests: switch some base images
Disable most packit copr targets
Cross-build on Fedora
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar Tag question here.

@TomSweeneyRedHat
Copy link
Member

LGTM, other than the tags question again.

@TomSweeneyRedHat
Copy link
Member

@rhatdan or @flouthoc or @Luap99 PTAL and merge if it LGTY

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: de1987, Luap99, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df0b920 into containers:release-1.35 Jan 24, 2025
29 checks passed
@nalind nalind deleted the v1.35.5 branch January 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/other lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants