Skip to content

Commit

Permalink
drop stdin for exec sync
Browse files Browse the repository at this point in the history
as i don't think there's a way it can be passed in

Signed-off-by: Peter Hunt~ <[email protected]>
  • Loading branch information
haircommander committed Sep 22, 2022
1 parent 0ad3325 commit 3c733ba
Show file tree
Hide file tree
Showing 3 changed files with 139 additions and 150 deletions.
1 change: 0 additions & 1 deletion conmon-rs/common/proto/conmon.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ interface Conmon {
timeoutSec @1 :UInt64;
command @2 :List(Text);
terminal @3 :Bool;
stdin @4 :Bool;
}

struct ExecSyncContainerResponse {
Expand Down
3 changes: 1 addition & 2 deletions conmon-rs/server/src/rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,11 @@ impl conmon::Server for Server {

let command = pry!(req.get_command());
let args = pry_err!(self.generate_exec_sync_args(&id, &pidfile, &container_io, &command));
let stdin = req.get_stdin();

Promise::from_future(
async move {
match child_reaper
.create_child(&runtime, &args, stdin, &mut container_io, &pidfile)
.create_child(&runtime, &args, false, &mut container_io, &pidfile)
.await
{
Ok((grandchild_pid, token)) => {
Expand Down
285 changes: 138 additions & 147 deletions internal/proto/conmon.capnp.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3c733ba

Please sign in to comment.