Add user namespaces support for pause
#1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
userns-pause
branch
4 times, most recently
from
80696e7 to
9168193
Compare
rphillips
reviewed
Jan 30, 2023
We now add support for UID and GID mappings which are required for unsharing user namespaces in `conmonrs pause`. Fixes containers#1043 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
userns-pause
branch
from
9168193 to
7efcfcd
Compare
|
@rphillips @haircommander PTAL (again) |
|
lgtm |
|
/lgtm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We now add support for UID and GID mappings which are required for unsharing user namespaces in
conmonrs pause.Which issue(s) this PR fixes:
Fixes #1043
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?