Bind missing namespaces to host #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We now bind all namespaces, independently if unshared or not. If a namespace is not being unshared, then we fallback to the host. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
all-namespaces
branch
from
b49bd84 to
511228e
Compare
|
@haircommander @rphillips PTAL |
|
/lgtm |
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We now bind all namespaces, independently if unshared or not. If a namespace is not being unshared, then we fallback to the host.
Which issue(s) this PR fixes:
Required for cri-o/cri-o#6590
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?