Use zeitgeist for dependency verification #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
zeitgeist
branch
from
4947a20 to
e5faf8f
Compare
rphillips
reviewed
Feb 1, 2023
rphillips
reviewed
Feb 1, 2023
rphillips
reviewed
Feb 1, 2023
| match: GO_VERSION | ||
|
|
||
| - name: rust | ||
| version: 1.58.1 |
There was a problem hiding this comment.
Can we use a newer version of rust?
There was a problem hiding this comment.
I don't think so. Maybe @lsm5 has more input on when to expect new rust versions on RHEL / RHCOS 8/9.
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
zeitgeist
branch
from
e5faf8f to
b3e48d3
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
What this PR does / why we need it:
We now use a dedicated job for verifying our dependencies while pinning them in
dependencies.yaml.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?