Update golangci-lint and config #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
commented
Feb 3, 2023
| @@ -91,6 +93,7 @@ linters: | |||
| - whitespace | |||
| - wrapcheck | |||
| # - exhaustruct | |||
| # - ginkgolinter | |||
There was a problem hiding this comment.
Seems to crash, we can try to enable it again at some later point in time.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 33.92% 33.69% -0.24%
==========================================
Files 13 13
Lines 1126 1119 -7
Branches 391 387 -4
==========================================
- Hits 382 377 -5
- Misses 486 487 +1
+ Partials 258 255 -3 |
saschagrunert
force-pushed
the
golangci-lint
branch
from
7889abf to
47f5d5d
Compare
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
golangci-lint
branch
from
47f5d5d to
29c12bd
Compare
|
@rphillips @haircommander PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
What this PR does / why we need it:
Update golangci lint to the latest version and enable linters.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?