[CI:BUILD] Packit: initial enablement #1104
Conversation
|
I haven't enabled i686 packit builds cause I don't want to bother with those for podman and others either. Hope that's alright :D |
|
hmm, where's the version specified? don't see it in Cargo.toml . I think we can do without it as the release field of the generated rpms will show the HEAD commit id and the PR #. |
|
@lsm5 we have the versions in |
ah ok, I'll update the PR. thanks! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
+ Coverage 34.31% 34.76% +0.44%
==========================================
Files 13 13
Lines 1119 1119
Branches 391 389 -2
==========================================
+ Hits 384 389 +5
+ Misses 479 467 -12
- Partials 256 263 +7 |
This commit will run COPR builds on every PR against all active releases of CentOS Stream and Fedora, thus allowing buildability checks before the PR merges. Builds are done on a custom COPR project: `rhcontainerbot/packit-builds`. Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/ The build targets are set in the copr itself, so we don't need to explicitly mention them in `.packit.yaml`, making upstream configuration a lot simpler. The `spec.rpkg` file meant for rpm builds post-pr-merge at `rhcontainerbot/podman-next` copr gets reused for packit builds, so the packit jobs are independent of Fedora / CentOS dist-git. Fixes: containers#1103 Signed-off-by: Lokesh Mandvekar <[email protected]>
|
@saschagrunert @haircommander PTAL. Also, |
third time's the charm 😄 |
|
errrr wait ... let me make a few comment fixes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
nvm, the comment fixes can go in later. no biggie. |
This commit will run COPR builds on every PR against all active releases of CentOS Stream and Fedora, thus allowing buildability checks before the PR merges.
Builds are done on a custom COPR project:
rhcontainerbot/packit-builds.Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/
The build targets are set in the copr itself, so we don't need to explicitly mention them in
.packit.yaml, making upstream configuration a lot simpler.The
spec.rpkgfile meant for rpm builds post-pr-merge atrhcontainerbot/podman-nextcopr gets reused for packit builds, so the packit jobs are independent of Fedora / CentOS dist-git.Fixes: #1103
Signed-off-by: Lokesh Mandvekar [email protected]
What type of PR is this?
/kind ci
What this PR does / why we need it:
Checks for fedora and centos stream buildability pre-merge.
Which issue(s) this PR fixes:
Fixes #1103
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?