-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable packit for main
branch
#1108
Enable packit for main
branch
#1108
Conversation
Signed-off-by: Sascha Grunert <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
==========================================
- Coverage 33.60% 33.51% -0.09%
==========================================
Files 13 13
Lines 1119 1119
Branches 387 387
==========================================
- Hits 376 375 -1
- Misses 486 487 +1
Partials 257 257 |
@saschagrunert I'm cool with this but do we actually need the |
I assume we have to override I got the example from https://packit.dev/docs/configuration/#packit-service-jobs |
@saschagrunert i've pinged the packit people to understand |
Sounds good, PTAL @haircommander @rphillips |
/lgtm |
so packit guys showered some knowledge. So, |
oops did I merge too early |
na ... there can be another PR :D |
only difference with |
@saschagrunert webhook disabled. if you wanna do a new PR with the |
What type of PR is this?
/kind ci
What this PR does / why we need it:
Enable packit builds for the main branch.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
PTAL @lsm5
Does this PR introduce a user-facing change?