Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable packit for main branch #1108

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 14, 2023

What type of PR is this?

/kind ci

What this PR does / why we need it:

Enable packit builds for the main branch.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

PTAL @lsm5

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #1108 (3a67411) into main (01c390c) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   33.60%   33.51%   -0.09%     
==========================================
  Files          13       13              
  Lines        1119     1119              
  Branches      387      387              
==========================================
- Hits          376      375       -1     
- Misses        486      487       +1     
  Partials      257      257              

@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

@saschagrunert I'm cool with this but do we actually need the trigger: commit ? IIUC, it triggers builds after the commit is done, which is already being done by the webhook on rhcontainerbot/podman-next copr. Correct me if I'm wrong.

@saschagrunert
Copy link
Member Author

saschagrunert commented Feb 14, 2023

@saschagrunert I'm cool with this but do we actually need the trigger: commit ? IIUC, it triggers builds after the commit is done, which is already being done by the webhook on rhcontainerbot/podman-next copr. Correct me if I'm wrong.

I assume we have to override trigger: pull_request from the above &copr link, so yes?! 🤔

I got the example from https://packit.dev/docs/configuration/#packit-service-jobs

@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

@saschagrunert I'm cool with this but do we actually need the trigger: commit ? IIUC, it triggers builds after the commit is done, which is already being done by the webhook on rhcontainerbot/podman-next copr. Correct me if I'm wrong.

I assume we have to override trigger: pull_request from the above &copr link, so yes?! thinking

I got the example from https://packit.dev/docs/configuration/#packit-service-jobs

@saschagrunert i've pinged the packit people to understand trigger: commit cause right now I find it redundant along with the prior webhook. But if you wanna go ahead, by all means 🙂 . If things blow up we'll soon find out 😄

@saschagrunert
Copy link
Member Author

Sounds good, PTAL @haircommander @rphillips

@haircommander
Copy link
Collaborator

/lgtm

@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

so packit guys showered some knowledge. So, trigger: commit serves the same purpose as the webhook to rhcontainerbot/podman-next but with some additional status reporting on github itself. So, I think we can remove the webhook but we should also mention the copr project where the after-commit build should be sent to.

@openshift-merge-robot openshift-merge-robot merged commit 7b2a32a into containers:main Feb 14, 2023
@haircommander
Copy link
Collaborator

oops did I merge too early

@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

na ... there can be another PR :D

@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

only difference with trigger: commit would be project: podman-next and then we disable the earlier webhook

@saschagrunert saschagrunert deleted the packit-main branch February 14, 2023 14:51
@lsm5
Copy link
Member

lsm5 commented Feb 14, 2023

only difference with trigger: commit would be project: podman-next and then we disable the earlier webhook

@saschagrunert webhook disabled. if you wanna do a new PR with the project change, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants