Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set release build debug flag to 0 #1409

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

The initial goal was to exclude the debug symbols, not to include them.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

The initial goal was to exclude the debug symbols, not to include them.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1409 (3c464e7) into main (aad5e56) will increase coverage by 0.70%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   33.92%   34.62%   +0.70%     
==========================================
  Files          13       13              
  Lines        1135     1135              
  Branches      394      393       -1     
==========================================
+ Hits          385      393       +8     
+ Misses        491      483       -8     
  Partials      259      259              

@saschagrunert
Copy link
Member Author

@haircommander PTAL

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2f46b0e into containers:main Jun 22, 2023
@saschagrunert saschagrunert deleted the debug branch June 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants