Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitMinimal nix build dependency #2366

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 5, 2024

What type of PR is this?

/kind ci

What this PR does / why we need it:

This allows to output the tag and commit in conmonrs --version.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed `conmonrs --version` output for static builds to include the `tag` and `commit` fields.

This allows to output the `tag` and `commit` in `conmonrs --version`.

Signed-off-by: Sascha Grunert <[email protected]>
Comment on lines -3 to -5
# TODO: Switch back to glibc when
# https://github.com/NixOS/nixpkgs/issues/306473
# is resolved.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing that comment since we'll not switch back.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.26%. Comparing base (4e0f474) to head (192bb3d).
Report is 658 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
- Coverage   37.53%   37.26%   -0.28%     
==========================================
  Files          15       15              
  Lines        1268     1264       -4     
  Branches      414      418       +4     
==========================================
- Hits          476      471       -5     
+ Misses        526      524       -2     
- Partials      266      269       +3     

@saschagrunert
Copy link
Member Author

@kwilczynski PTAL

@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e545fdf into containers:main Aug 5, 2024
33 checks passed
@saschagrunert saschagrunert deleted the git branch August 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants