-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitMinimal
nix build dependency
#2366
Conversation
This allows to output the `tag` and `commit` in `conmonrs --version`. Signed-off-by: Sascha Grunert <[email protected]>
# TODO: Switch back to glibc when | ||
# https://github.com/NixOS/nixpkgs/issues/306473 | ||
# is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing that comment since we'll not switch back.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
- Coverage 37.53% 37.26% -0.28%
==========================================
Files 15 15
Lines 1268 1264 -4
Branches 414 418 +4
==========================================
- Hits 476 471 -5
+ Misses 526 524 -2
- Partials 266 269 +3 |
@kwilczynski PTAL |
/approve |
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind ci
What this PR does / why we need it:
This allows to output the
tag
andcommit
inconmonrs --version
.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?